Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prototype runtime --todo] Consider accessibility mismatch #1539

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[prototype runtime --todo] Consider accessibility mismatch #1539

merged 1 commit into from
Oct 30, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Sep 22, 2023

For example, the current Kernel#initialize_copy is defined as a public method in RBS, but it's actually a private method. This fact was discovered through the implementation of this PR.
Such accessibility inconsistencies should also be detected as part of the "todo" items.

@ksss ksss mentioned this pull request Sep 22, 2023
Merged
soutaro
soutaro approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.3 milestone Oct 30, 2023
@soutaro soutaro added this pull request to the merge queue Oct 30, 2023
Merged via the queue into ruby:master with commit 388e5f0 Oct 30, 2023
23 checks passed
@ksss ksss deleted the todo-accessibility branch October 30, 2023 07:10
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro